From c8d55a78ee3f5fce518f71478e20c69eaae6c638 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 20 Jan 2011 21:49:06 +0100 Subject: [PATCH] maint.mk: make "check" depend on public-submodule-commit by default * top/maint.mk (GL_PUBLIC_SUBMODULE_COMMIT): New overridable variable. --- ChangeLog | 5 +++++ top/maint.mk | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/ChangeLog b/ChangeLog index 8ac17f98b..be6a9edc8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-01-20 Jim Meyering + + maint.mk: make "check" depend on public-submodule-commit by default + * top/maint.mk (GL_PUBLIC_SUBMODULE_COMMIT): New overridable variable. + 2011-01-20 Bruno Haible mbfile, mbiter: Complete change from 2008-12-21. diff --git a/top/maint.mk b/top/maint.mk index 25f4736a3..c57acd345 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -1134,6 +1134,14 @@ public-submodule-commit: else \ : ; \ fi +# This rule has a high enough utility/cost ratio that it should be a +# dependent of "check" by default. However, some of us do occasionally +# commit a temporary change that deliberately points to a non-public +# submodule commit, and want to be able to use rules like "make check". +# In that case, run e.g., "make check GL_PUBLIC_SUBMODULE_COMMIT=" +# to disable this test. +GL_PUBLIC_SUBMODULE_COMMIT ?= public-submodule-commit +check: $(GL_PUBLIC_SUBMODULE_COMMIT) .PHONY: alpha beta stable ALL_RECURSIVE_TARGETS += alpha beta stable -- 2.11.0