From 8129b787e22444055521ada1101aaaf8050c58a6 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 29 Dec 2010 01:25:46 -0800 Subject: [PATCH] ftoastr, snprintf: ftoastr + snprintf module * lib/ftoastr.c: Use GNULIB_SNPRINTF, not GNULIB_SNPRINTF_POSIX, since the snprintf module now should be good enough here. * modules/snprintf (configure.ac): Add gl_MODULE_INDICATOR([snprintf]). It seems odd to have both gl_STDIO_MODULE_INDICATOR([snprintf]) and gl_MODULE_INDICATOR([snprintf]), but the former enables GNULIB_SNPRINTF only for the test directory, and the latter doesn't arrange for gl_STDIO_H_DEFAULTS to be called, so neither seems to suffice by itself. --- ChangeLog | 12 ++++++++++++ lib/ftoastr.c | 2 +- modules/snprintf | 1 + 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 5c95bc4e7..021102c7f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2010-12-29 Paul Eggert + + ftoastr, snprintf: ftoastr + snprintf module + * lib/ftoastr.c: Use GNULIB_SNPRINTF, not GNULIB_SNPRINTF_POSIX, + since the snprintf module now should be good enough here. + * modules/snprintf (configure.ac): Add gl_MODULE_INDICATOR([snprintf]). + It seems odd to have both gl_STDIO_MODULE_INDICATOR([snprintf]) + and gl_MODULE_INDICATOR([snprintf]), but the former enables + GNULIB_SNPRINTF only for the test directory, and the latter + doesn't arrange for gl_STDIO_H_DEFAULTS to be called, so neither + seems to suffice by itself. + 2010-12-28 Paul Eggert alloca: one step towards thread-safety diff --git a/lib/ftoastr.c b/lib/ftoastr.c index a55b24eb9..49f721b4d 100644 --- a/lib/ftoastr.c +++ b/lib/ftoastr.c @@ -69,7 +69,7 @@ /* On hosts where it's not known that snprintf works, use sprintf to implement the subset needed here. Typically BUFSIZE is big enough and there's little or no performance hit. */ -#if ! GNULIB_SNPRINTF_POSIX +#if ! GNULIB_SNPRINTF # undef snprintf # define snprintf ftoastr_snprintf static int diff --git a/modules/snprintf b/modules/snprintf index 27c343eba..e8b5dfb47 100644 --- a/modules/snprintf +++ b/modules/snprintf @@ -14,6 +14,7 @@ errno configure.ac: gl_FUNC_SNPRINTF gl_STDIO_MODULE_INDICATOR([snprintf]) +gl_MODULE_INDICATOR([snprintf]) Makefile.am: -- 2.11.0