From 2eb7a002f89b86fbced9214ffb959e53aaae0548 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Sun, 27 Apr 2008 23:30:18 +0200 Subject: [PATCH] Add some comments. --- ChangeLog | 5 +++++ lib/rpmatch.c | 11 ++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 391bb3f57..dfd8ca3ad 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2008-04-27 Bruno Haible + * lib/rpmatch.c (rpmatch): Add some comments. + Reported by James Youngman . + +2008-04-27 Bruno Haible + * m4/isnanl.m4 (gl_FUNC_ISNANL_WORKS): Also test the behaviour on quiet NaNs. diff --git a/lib/rpmatch.c b/lib/rpmatch.c index 826bc4c5e..f1b7071fd 100644 --- a/lib/rpmatch.c +++ b/lib/rpmatch.c @@ -1,7 +1,7 @@ /* Determine whether string value is affirmation or negative response according to current locale's data. - Copyright (C) 1996, 1998, 2000, 2002, 2003, 2006 Free Software + Copyright (C) 1996, 1998, 2000, 2002, 2003, 2006, 2008 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify @@ -61,6 +61,15 @@ rpmatch (const char *response) /* Match against one of the response patterns, compiling the pattern first if necessary. */ + /* We get the patterns from a PO file. It would be possible to use + nl_langinfo (YESEXPR) instead of _("^[yY]"), and nl_langinfo (NOEXPR) + instead of _("^[nN]"), if we could assume that the system's locale + support is good. But this is not the case e.g. on Cygwin. The + localizations of gnulib.pot are of better quality in general. + Also, if we used locale info from non-free systems that don't have a + 'localedef' command, we would deprive the users of the freedom to + localize this pattern for their preferred language. */ + /* We cache the response patterns and compiled regexps here. */ static const char *yesexpr, *noexpr; static regex_t yesre, nore; -- 2.11.0