From 2cbc4063244a149c6454b87eaa061fc290f1c6e3 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 12 Feb 2000 10:11:54 +0000 Subject: [PATCH] add FIXME comments for use of atoi --- lib/userspec.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/userspec.c b/lib/userspec.c index fe2596858..135a36c5d 100644 --- a/lib/userspec.c +++ b/lib/userspec.c @@ -183,7 +183,10 @@ parse_user_spec (const char *spec_arg, uid_t *uid, gid_t *gid, if (use_login_group) error_msg = "cannot get the login group of a numeric UID"; else - *uid = atoi (u); + { + /* FIXME: don't use atoi! */ + *uid = atoi (u); + } } } else @@ -223,7 +226,10 @@ parse_user_spec (const char *spec_arg, uid_t *uid, gid_t *gid, if (!is_number (g)) error_msg = "invalid group"; else - *gid = atoi (g); + { + /* FIXME: don't use atoi! */ + *gid = atoi (g); + } } else *gid = grp->gr_gid; -- 2.11.0