Ian Beckwith [Thu, 9 Jun 2011 18:54:58 +0000 (19:54 +0100)]
NEWS.stable: update
Eric Blake [Tue, 24 May 2011 23:33:39 +0000 (17:33 -0600)]
docs: document recently fixed glibc printf bug
Document it as a known bug, but one where we don't provide a
workaround since programmers are unlikely to hit it in practice.
* doc/posix-functions/fprintf.texi (fprintf): Document it.
* doc/posix-functions/printf.texi (printf): Likewise.
* doc/posix-functions/vfprintf.texi (vfprintf): Likewise.
* doc/posix-functions/vprintf.texi (vprintf): Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com>
(cherry picked from commit
f4c4af09bcf3f0497dc3347ecc0a0b3c9ee1ff63)
Ian Beckwith [Thu, 9 Jun 2011 18:52:39 +0000 (19:52 +0100)]
NEWS.stable: update
Eric Blake [Tue, 24 May 2011 22:42:37 +0000 (16:42 -0600)]
atexit-tests: ensure reliable exit status
This was the only remaining init.sh client that didn't properly
use the 'Exit' function.
* tests/test-atexit.sh: Prefer 'Exit' over 'exit'.
Reported by Bruno Haible.
Signed-off-by: Eric Blake <eblake@redhat.com>
(cherry picked from commit
fc9b0f6cfa9e0e148a79e51150c8171d617474f2)
Ian Beckwith [Thu, 9 Jun 2011 18:50:51 +0000 (19:50 +0100)]
NEWS.stable: log cherry-pick [
866bbae]->[
b9bb8b9] tests: fix logic bug in init.sh
Eric Blake [Tue, 24 May 2011 16:04:46 +0000 (10:04 -0600)]
tests: fix logic bug in init.sh
If the shell test loop first finds a marginal then a good shell, the
variable $gl_set_x_corrupts_stderr is still set to true and needlessly
drops $VERBOSE logging.
* tests/init.sh: (gl_set_x_corrupts_stderr_): Clear for successful
shell.
Signed-off-by: Eric Blake <eblake@redhat.com>
(cherry picked from commit
866bbaee7bf64b5f54b2b3d566552782dfb514dd)
Ian Beckwith [Thu, 9 Jun 2011 18:50:06 +0000 (19:50 +0100)]
NEWS.stable: log cherry-pick [
6dc42e2]->[
d0fe920] utimensat: do not reference an out-of-scope buffer
Jim Meyering [Tue, 24 May 2011 16:24:24 +0000 (18:24 +0200)]
utimensat: do not reference an out-of-scope buffer
Otherwise, with __linux__ defined, "times" would point to a buffer, "ts"
declared in an inner scope, yet "times" would be dereferenced outside
the scope in which "ts" was valid.
* lib/utimensat.c (rpl_utimensat) [__linux__]: Move the declaration
of ts[2] "out/up", so that the use of aliased "times" (via "times = ts;")
does not end up referencing an out-of-scope "ts"
(cherry picked from commit
6dc42e2d25df9c84b335062bad9beb0a7319647b)
Ian Beckwith [Thu, 9 Jun 2011 18:49:51 +0000 (19:49 +0100)]
NEWS.stable: log cherry-pick [
d94bbd1]->[
4af1887] opendir-safer.c: don't clobber errno; don't close negative FD
Jim Meyering [Tue, 24 May 2011 11:44:41 +0000 (13:44 +0200)]
opendir-safer.c: don't clobber errno; don't close negative FD
* lib/opendir-safer.c (opendir_safer):
[HAVE_FDOPENDIR || GNULIB_FDOPENDIR]: Don't close a negative
file descriptor, and more importantly, don't clobber the
offending errno value with EINVAL. Before, upon failure
of dup_safer, we would pass the negative file descriptor to
fdopendir, which would clobber errno.
(cherry picked from commit
d94bbd1eb1fc483d72397ec5dd94f7e885e12440)
Ian Beckwith [Thu, 9 Jun 2011 18:47:38 +0000 (19:47 +0100)]
NEWS.stable: log cherry-pick [
1e8752a]->[
4831e70] Fix recent ChangeLog entry.
Bruno Haible [Mon, 23 May 2011 22:19:52 +0000 (00:19 +0200)]
Fix recent ChangeLog entry.
(cherry picked from commit
1e8752a054ac477dd9323d448967f770542a594a)
Ian Beckwith [Thu, 9 Jun 2011 18:47:21 +0000 (19:47 +0100)]
NEWS.stable: log cherry-pick [
59ed6e8]->[
1166200] idcache: Fix module description.
Bruno Haible [Mon, 23 May 2011 22:14:15 +0000 (00:14 +0200)]
idcache: Fix module description.
* modules/idcache (Include): Set to "idcache.h".
(cherry picked from commit
59ed6e827f34ae3f31927ef5f95cf76daab1cf79)
Ian Beckwith [Thu, 9 Jun 2011 18:47:09 +0000 (19:47 +0100)]
NEWS.stable: log cherry-pick [
ddd54c7]->[
cd78e73] gnulib-tool: fix portability problem with MacOS sed
Paul Eggert [Mon, 23 May 2011 22:02:43 +0000 (15:02 -0700)]
gnulib-tool: fix portability problem with MacOS sed
A sed command like "/x/{s/a/b/}" is not portable; a newline is needed
before the "}". Problem reported by Leo in
<http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00717.html>.
* gnulib-tool (sed_dependencies_without_conditions):
(cherry picked from commit
ddd54c759aedbcabfb17335dab690ce79c5a53b4)
Ian Beckwith [Thu, 9 Jun 2011 18:46:31 +0000 (19:46 +0100)]
NEWS.stable: update
Bruno Haible [Mon, 23 May 2011 21:47:00 +0000 (23:47 +0200)]
getugroups: Fix module description.
* modules/getugroups (Include): Set to "getugroups.h".
(cherry picked from commit
fbd3cc52618eabae9602095c70d33364bd4d0a9c)
Ian Beckwith [Thu, 9 Jun 2011 18:44:38 +0000 (19:44 +0100)]
NEWS.stable: update
Bruno Haible [Mon, 23 May 2011 19:46:00 +0000 (21:46 +0200)]
linkat, renameat: Update dependencies.
* modules/renameat (Depends-on): Add dosname, save-cwd. Remove stpcpy.
* modules/linkat (Depends-on): Likewise. Remove also readlink,
symlinkat.
(cherry picked from commit
64c633297a293c2405730fc66eb3c7d886a37c91)
Ian Beckwith [Thu, 9 Jun 2011 18:22:22 +0000 (19:22 +0100)]
NEWS.stable: update
Paul Eggert [Mon, 23 May 2011 01:36:04 +0000 (18:36 -0700)]
verify: fix bug when gnulib <assert.h> is also included
* lib/verify.h (verify, verify_true): Define if _GL_VERIFY_H
is defined, not if _GL_STATIC_ASSERT_H is not defined.
Perhaps there's a better way, but this fixes the immediate problem.
Problem reported by Bruno Haible in
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00478.html>.
(cherry picked from commit
99b313868bb6a7441f762d78252ce418f5ca7fdb)
Ian Beckwith [Thu, 9 Jun 2011 17:50:44 +0000 (18:50 +0100)]
NEWS.stable: log cherry-pick [
6c8bcfc]->[
617bbef] * doc/intprops.texi: fix typo in copyright date
Paul Eggert [Sun, 22 May 2011 20:31:38 +0000 (13:31 -0700)]
* doc/intprops.texi: fix typo in copyright date
(cherry picked from commit
6c8bcfcbed6270ca5eb50d94d324d81157a5c912)
Ian Beckwith [Thu, 9 Jun 2011 17:48:03 +0000 (18:48 +0100)]
NEWS.stable: log cherry-pick [
21eb071]->[
8694861] clock-time: change to LGPLv2+.
Paul Eggert [Sun, 22 May 2011 03:25:03 +0000 (20:25 -0700)]
clock-time: change to LGPLv2+.
* modules/clock-time: Change from GPL to LGPLv2+. Actually, it's
BSD-like but we have no mark for that; this is good enough for now.
(cherry picked from commit
21eb0710bf49def4db1ddc6f710a3ea5e79461f9)
Ian Beckwith [Thu, 9 Jun 2011 17:47:46 +0000 (18:47 +0100)]
NEWS.stable: update
Bruno Haible [Sat, 21 May 2011 21:41:37 +0000 (23:41 +0200)]
relocatable-prog-wrapper: Fix possible link error.
* m4/setenv.m4 (gl_FUNC_SETENV_SEPARATE): Move determination of
HAVE_SETENV and REPLACE_SETENV and AC_LIBOBJ invocation from here...
(gl_FUNC_SETENV): ... to here.
* m4/canonicalize.m4 (gl_CANONICALIZE_LGPL_SEPARATE): Update comment.
* m4/readlink.m4 (gl_FUNC_READLINK_SEPARATE): Likewise.
(cherry picked from commit
325f131b3d6bdf1b14644f51606d81ee98f6867b)
Ian Beckwith [Thu, 9 Jun 2011 17:36:06 +0000 (18:36 +0100)]
NEWS.stable: log cherry-pick [
93d7550]->[
0cc5541] maint: replace misused "a" with "an"
Jim Meyering [Fri, 20 May 2011 09:53:34 +0000 (11:53 +0200)]
maint: replace misused "a" with "an"
* doc/intprops.texi: "a integer"
* doc/regex.texi: "a explanation"
* lib/alignof.h: "a object"
* lib/argmatch.h: "a explanation"
* lib/argp-help.c: "a option" and "a OPTION_DOC"
* lib/stdint.in.h: "a integer"
* lib/userspec.c: "a owner"
* doc/gnulib.texi: Fix "a idea", and reword.
(cherry picked from commit
93d7550462f21202b69712f3d489399963965ddd)
Ian Beckwith [Thu, 9 Jun 2011 17:35:55 +0000 (18:35 +0100)]
NEWS.stable: log cherry-pick [
c9ff025]->[
056b00f] maint: correct misuse of "a" and "an"
Jim Meyering [Thu, 19 May 2011 20:18:05 +0000 (22:18 +0200)]
maint: correct misuse of "a" and "an"
* doc/regex.texi (Collating Symbol Operators): s/an close.../a close/
* lib/argp-help.c: "an docum...": s/an/a/
* lib/argp-parse.c: "An vector": s/An/A/
* lib/execute.c: "an native": s/an/a/
* lib/spawn-pipe.c: Likewise.
* lib/gc.h: "an Gc_rc": s/an/a/
* lib/unigbrk.in.h: "an grapheme": s/an/a/
* lib/fts.c: "an stat.st_dev": s/an/a/
(cherry picked from commit
c9ff025783e5374226ffbf7940f40ce7db6852ed)
Ian Beckwith [Thu, 9 Jun 2011 17:35:43 +0000 (18:35 +0100)]
NEWS.stable: update
Paul Eggert [Fri, 20 May 2011 02:16:04 +0000 (19:16 -0700)]
intprops: work around IRIX 6.5 cc bug with 0u - 0u + -1
See http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00406.html
* lib/intprops.h (_GL_INT_NEGATE_CONVERT): New macro.
(_GL_INT_SIGNED, _GL_INT_MAXIMUM, _GL_DIVIDE_OVERFLOW):
(_GL_REMAINDER_OVERFLOW): Use it.
(cherry picked from commit
92c71a1c8324e3f0776fd0edb3fc400b4d04a592)
Ian Beckwith [Thu, 9 Jun 2011 17:13:48 +0000 (18:13 +0100)]
NEWS.stable: log cherry-pick [
8cc0fee]->[
8c5e817] intprops: work around C compiler bugs
Paul Eggert [Thu, 19 May 2011 08:36:25 +0000 (01:36 -0700)]
intprops: work around C compiler bugs
* lib/intprops.h (INT_MULTIPLY_RANGE_OVERFLOW): Work around compiler
bug in Sun C 5.11 2010/08/13 and other compilers; see
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00401.html>.
(cherry picked from commit
8cc0fee0550bac55e1c1244366308eed1d16bb82)
Ian Beckwith [Thu, 9 Jun 2011 17:08:40 +0000 (18:08 +0100)]
NEWS.stable: update
Paul Eggert [Thu, 19 May 2011 08:34:14 +0000 (01:34 -0700)]
intprops: TYPE_IS_INTEGER, TYPE_SIGNED not integer constant exprs
* doc/intprops.texi (Integer Type Determination): Fix
documentation for TYPE_IS_INTEGER: it returns an constant
expression, not an integer constant expression. Fix doc for
TYPE_SIGNED: it returns an integer constant expression only if its
argument is an integer type. (TYPE_IS_INTEGER is the same, but is
hardly worth documented that way....)
(cherry picked from commit
48cc7484c740d7f0e84fccd1fde11059986e3b94)
Ian Beckwith [Wed, 18 May 2011 22:12:22 +0000 (23:12 +0100)]
Merge branch 'upstream' into stable
Conflicts:
ChangeLog
build-aux/depcomp
build-aux/texinfo.tex
m4/getaddrinfo.m4
top/maint.mk
Eric Blake [Wed, 18 May 2011 19:13:03 +0000 (13:13 -0600)]
fnmatch: avoid compiler warning
Detected on Ubuntu 10.04, where the glibc fnmatch fix is not yet
present; also reproduced via:
$ gl_cv_func_fnmatch_posix=no CFLAGS=-Wall \
./gnulib-tool --with-tests --test fnmatch
In file included from gllib/fnmatch.c:172:0:
gllib/fnmatch_loop.c: In function ‘internal_fnmatch’:
gllib/fnmatch_loop.c:203:28: error: initialization discards qualifiers from pointer target type
gllib/fnmatch_loop.c:204:28: error: initialization discards qualifiers from pointer target type
* lib/fnmatch_loop.c (FCT): Use correct type.
Reported by Matthias Bolte.
Signed-off-by: Eric Blake <eblake@redhat.com>
Jim Meyering [Fri, 13 May 2011 21:35:48 +0000 (23:35 +0200)]
maint.mk: three new prohibit_<HDR>_without_use rules
* top/maint.mk (sc_prohibit_stdio--_without_use): New rule.
(sc_prohibit_stdio-safer_without_use): Likewise.
(sc_prohibit_xfreopen_without_use): Likewise.
Jim Meyering [Tue, 17 May 2011 20:24:59 +0000 (22:24 +0200)]
announce-gen: fail if the NEWS delta is empty
If there's nothing noteworthy in NEWS, then either you forgot
or you shouldn't be releasing.
* build-aux/announce-gen: Die if the NEWS delta is effectively empty.
Pádraig Brady [Tue, 17 May 2011 18:08:14 +0000 (19:08 +0100)]
maint.mk: exclude compiler symbols from sc_tight_scope
Paul Eggert [Tue, 17 May 2011 20:09:08 +0000 (13:09 -0700)]
intprops: add doc
* doc/intprops.texi: New file, documenting intprops.
* doc/gnulib.texi (Particular Modules): Include it.
Paul Eggert [Tue, 17 May 2011 20:07:28 +0000 (13:07 -0700)]
verify: add doc to gnulib manual and fix example
* doc/gnulib.texi (Compile-time Assertions): New node, for 'verify'.
* doc/verify.texi (Compile-time Assertions): Update 'assert' doc.
(Compile-time Assertions): Fix example so it can't overflow.
Jim Meyering [Tue, 17 May 2011 12:10:16 +0000 (14:10 +0200)]
warnings.m4: don't usurp save_CPPFLAGS variable name
* m4/warnings.m4: Prefix local temporary variable name with gl_.
Jim Meyering [Tue, 17 May 2011 06:19:00 +0000 (08:19 +0200)]
ChangeLog: s/^ /\t/
Jim Meyering [Tue, 17 May 2011 06:17:42 +0000 (08:17 +0200)]
doc: fix typo
* doc/gnulib-intro.texi (Target Platforms): s/is/are/
Paul Eggert [Tue, 17 May 2011 00:23:22 +0000 (02:23 +0200)]
doc: Tweak recent change.
* README (Portability guidelines): Tweak new text.
* doc/gnulib-intro.texi (Target Platforms): Likewise. Mention
Interix 6.1.
Eric Blake [Mon, 16 May 2011 23:20:47 +0000 (17:20 -0600)]
inttypes: avoid autoconf warning
I noticed this while updating libvirt to the latest gnulib.
configure.ac:80: warning: AC_REQUIRE: `gl_STDINT_H' was expanded before it was required
gnulib/m4/inttypes.m4:18: gl_INTTYPES_INCOMPLETE is expanded from...
gnulib/m4/inttypes.m4:12: gl_INTTYPES_H is expanded from...
gnulib/m4/gnulib-comp.m4:379: gl_INIT is expanded from...
configure.ac:80: the top level
* m4/inttypes.m4 (gl_INTTYPES_INCOMPLETE): Only expand once.
* m4/stdint.m4 (gl_STDINT_H): Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com>
Bruno Haible [Mon, 16 May 2011 22:45:12 +0000 (00:45 +0200)]
Typo.
Eric Blake [Mon, 16 May 2011 22:02:07 +0000 (16:02 -0600)]
vc-list-files: accept multiple directory operands
* build-aux/vc-list-files: Iterate over all remaining operands.
Signed-off-by: Eric Blake <eblake@redhat.com>
Bruno Haible [Mon, 16 May 2011 22:27:54 +0000 (00:27 +0200)]
Fix confusion regarding deprecated modules.
* modules/calloc (Status, Notice): Mark module as deprecated, not
obsolete.
* modules/fnmatch-posix (Status, Notice): Likewise.
* modules/getdate (Status, Notice): Likewise.
* modules/getopt (Status, Notice): Likewise.
* modules/malloc (Status, Notice): Likewise.
* modules/pipe (Status, Notice): Likewise.
* modules/realloc (Status, Notice): Likewise.
* modules/rename-dest-slash (Status, Notice): Likewise.
* modules/unictype/bidicategory-all (Status, Notice): Likewise.
* modules/unictype/bidicategory-byname (Status, Notice): Likewise.
* modules/unictype/bidicategory-name (Status, Notice): Likewise.
* modules/unictype/bidicategory-of (Status, Notice): Likewise.
* modules/unictype/bidicategory-test (Status, Notice): Likewise.
Bruno Haible [Mon, 16 May 2011 22:25:35 +0000 (00:25 +0200)]
doc: List the target platforms.
* doc/gnulib-intro.texi (Target Platforms): New section.
* doc/gnulib.texi (Introduction): Update menu.
* README (Portability guidelines): Refer to the new section. Update
statement about oldest supported environment. Remove rationale why
<errno.h>, <string.h>, <stdlib.h> are assumed. Update example of an
unportable C89 function.
Reported by Bastien Roucariès <roucaries.bastien@gmail.com> and
Charles Wilson <cygwin@cwilson.fastmail.fm>. Feedback from Paul Eggert.
Paul Eggert [Mon, 16 May 2011 16:17:48 +0000 (09:17 -0700)]
* build-aux/bootstrap (gnulib_tool): Handle symlink timestamps better.
Paul Eggert [Sun, 15 May 2011 16:37:21 +0000 (09:37 -0700)]
intprops-tests: new module
* modules/intprops-tests, tests/test-intprops.c: New files.
Paul Eggert [Sun, 15 May 2011 16:35:12 +0000 (09:35 -0700)]
intprops: add safe, portable integer overflow checking
* lib/intprops.h (_GL_INT_CONVERT, _GL_INT_TWOS_COMPLEMENT):
(_GL_INT_SIGNED, _GL_INT_MINIMUM, _GL_INT_MAXIMUM):
(_GL_SIGNED_INT_MINIMUM, INT_ADD_RANGE_OVERFLOW):
(INT__SUBTRACT__RANGE_OVERFLOW, INT_NEGATE_RANGE_OVERFLOW):
(INT_MULTIPLY_RANGE_OVERFLOW, INT_REMAINDER_RANGE_OVERFLOW):
(INT_LEFT_SHIFT_RANGE_OVERFLOW, _GL_ADD_OVERFLOW):
(_GL__SUBTRACT__OVERFLOW, _GL_MULTIPLY_OVERFLOW, _GL_DIVIDE_OVERFLOW):
(_GL_REMAINDER_OVERFLOW, _GL_UNSIGNED_NEG_MULTIPLE, INT_ADD_OVERFLOW):
(INT__SUBTRACT__OVERFLOW, INT_NEGATE_OVERFLOW, INT_MULTIPLY_OVERFLOW):
(INT_DIVIDE_OVERFLOW, INT_REMAINDER_OVERFLOW):
(INT_LEFT_SHIFT_OVERFLOW, _GL_BINARY_OP_OVERFLOW): New macros.
James Youngman [Thu, 12 May 2011 21:14:12 +0000 (22:14 +0100)]
fnmatch: add a test for glibc's Bugzilla bug #12378
* m4/fnmatch.m4: Use gnulib's fnmatch if the system fnmatch
doesn't allow the literal matching of a lone "[" (which is
required by POSIX).
* tests/test-fnmatch.c (main): Check that "[/b" matches itself.
James Youngman [Thu, 12 May 2011 21:14:11 +0000 (22:14 +0100)]
fnmatch: sync glibc change fixing Bugzilla bug #12378
* lib/fnmatch_loop.c (FCT): When matching '[' keep track of
beginning and fall back to matching as normal character if the
string ends before the matching ']' is found. This is what POSIX
requires.
Karl Berry [Fri, 13 May 2011 23:09:30 +0000 (16:09 -0700)]
update from texinfo
Eric Blake [Fri, 13 May 2011 16:26:08 +0000 (10:26 -0600)]
getcwd-lgpl: relax test for FreeBSD
getcwd(NULL, 1) mallocs a larger buffer on BSD, rather than failing
with ERANGE as on glibc. This behavior difference is not worth
coding around, as it is an uncommon use of getcwd in the first place.
* doc/posix-functions/getcwd.texi (getcwd): Document portability
issue.
* tests/test-getcwd-lgpl.c (main): Relax test.
Reported by Matthias Bolte.
Signed-off-by: Eric Blake <eblake@redhat.com>
Eric Blake [Thu, 12 May 2011 01:33:46 +0000 (19:33 -0600)]
test-fflush: silence compiler warning
Detected by clang.
* tests/test-fflush.c (main): Don't fclose a NULL pointer.
Signed-off-by: Eric Blake <eblake@redhat.com>
Bruno Haible [Thu, 12 May 2011 00:10:44 +0000 (02:10 +0200)]
canonicalize, canonicalize-lgpl: Avoid crash dialog on MacOS X.
* m4/canonicalize.m4 (gl_FUNC_REALPATH_WORKS): Add GL_NOCRASH code.
* modules/canonicalize (Depends-on): Add 'nocrash'.
* modules/canonicalize-lgpl (Depends-on): Likewise.
* doc/posix-functions/realpath.texi: Update platforms list.
Reported by Ryan Schmidt <ryandesign@macports.org>.
Bruno Haible [Thu, 12 May 2011 00:03:07 +0000 (02:03 +0200)]
group-member: Declare function in <unistd.h>.
* lib/unistd.in.h (group_member): New declaration.
* lib/group-member.h: Remove file.
* lib/group-member.c: Include <unistd.h> instead of group-member.h.
* tests/test-unistd-c++.cc: Check signature of group_member.
* m4/group-member.m4 (gl_FUNC_GROUP_MEMBER): Require
gl_UNISTD_H_DEFAULTS. Set HAVE_GROUP_MEMBER.
* m4/unistd_h.m4 (gl_UNISTD_H): Check whether group_member is declared.
(gl_UNISTD_H_DEFAULTS): Initialize GNULIB_GROUP_MEMBER,
HAVE_GROUP_MEMBER.
* modules/group-member (Files): Remove lib/group-member.h.
(Depends-on): Add unistd. Specify conditions.
(configure.ac): Invoke gl_UNISTD_MODULE_INDICATOR.
(Include): Change to <unistd.h>.
* modules/unistd (Makefile.am): Substitute GNULIB_GROUP_MEMBER,
HAVE_GROUP_MEMBER.
* NEWS: Mention the change.
* lib/euidaccess.c: Don't include group-member.h.
Bruno Haible [Thu, 12 May 2011 00:01:42 +0000 (02:01 +0200)]
group-member: Document module.
* doc/glibc-functions/group_member.texi: Mention the 'group-member'
module.
Bruno Haible [Thu, 12 May 2011 00:01:00 +0000 (02:01 +0200)]
fclose: Fix mistake earlier today.
* lib/fclose.c (rpl_fclose): Don't assume that EOF < 0.
Eric Blake [Wed, 11 May 2011 17:35:06 +0000 (11:35 -0600)]
fclose: preserve fflush errors
Caught by gcc -Werror=unused-but-set-variable.
* lib/fclose.c (rpl_fclose): Don't lose fflush errors.
Reported by Jim Meyering.
Signed-off-by: Eric Blake <eblake@redhat.com>
Eric Blake [Wed, 11 May 2011 17:21:01 +0000 (11:21 -0600)]
bootstrap: support a prereq of 'rpcgen -' on RHEL5
On RHEL 5, 'rpcgen --version' spews usage to stderr with status 1,
rather than a version string to stdout with status 0. But libvirt
merely requires a prereq of 'rpcgen -' - that is, it must exist,
but need not have a well-behaved --version.
* build-aux/bootstrap (check_versions): When no specific version
is required, merely check that the app produces an exit status
that indicates its existence.
Signed-off-by: Eric Blake <eblake@redhat.com>
Eric Blake [Wed, 11 May 2011 14:22:18 +0000 (08:22 -0600)]
maint.mk: drop redundant check
* top/maint.mk (sc_the_the): Delete; sc_prohibit_doubled_word does
the same but better.
Signed-off-by: Eric Blake <eblake@redhat.com>
Karl Berry [Wed, 11 May 2011 13:58:35 +0000 (06:58 -0700)]
autoupdate
Bruno Haible [Wed, 11 May 2011 11:14:46 +0000 (13:14 +0200)]
fclose: Fix possible link error.
* lib/fclose.c (rpl_fclose): Invoke _gl_unregister_fd, not
unregister_shadow_fd. Improve comments.
* lib/sockets.c (close_fd_maybe_socket): Add comments. Reported by
Eric Blake.
Jim Meyering [Wed, 11 May 2011 08:41:23 +0000 (10:41 +0200)]
maint.mk: adjust previous commit
Change "misc" in names to "undesirable_word_seq".
"misc" is rarely desirable, in a name ;-)
Define and use ignore_undesirable_word_sequence_RE_ properly.
Jim Meyering [Wed, 11 May 2011 08:07:32 +0000 (10:07 +0200)]
maint.mk: improve "can not" detection and generalize rule name
* top/maint.mk (sc_prohibit_misc): Renamed from sc_prohibit_can_not,
since we'll probably add a few more word pairs here.
Use the same technique as in sc_prohibit_doubled_word, so that
we recognize "can not" also when the words are separated by a newline.
Suggested by Eric Blake.
(perl_filename_lineno_text_): Define. Factored out of...
(prohibit_doubled_word_): ...here. Use the new definition.
(prohibit_misc_): New var. Use it here, too.
(prohibit_misc_RE_): New overridable variable.
Eric Blake [Tue, 10 May 2011 21:28:48 +0000 (15:28 -0600)]
fclose: avoid double close race when possible
Calling close(fileno(fp)) prior to fclose(fp) is racy in a
multi-threaded application - some other thread could open a new file,
which is then inadvertently closed by the fclose that we thought
should fail with EBADF. For mingw, this is no worse than the race
already present in close_fd_maybe_socket for calling closesocket()
prior to _close(), but for all other platforms, we might as well be
nice and avoid the race.
* lib/fclose.c (rpl_fclose): Rewrite to avoid double-close race on
all but WINDOWS_SOCKETS.
Signed-off-by: Eric Blake <eblake@redhat.com>
Bastien Roucariès [Tue, 10 May 2011 09:30:19 +0000 (11:30 +0200)]
openat: correct new comment
* lib/openat-proc.c (openat_proc_name): Correct the comment.
Jim Meyering [Tue, 10 May 2011 07:46:59 +0000 (09:46 +0200)]
openat: add comments
* lib/openat-proc.c (openat_proc_name): Add comments,
mostly from Eric Blake.
Eric Blake [Mon, 9 May 2011 22:27:35 +0000 (16:27 -0600)]
openat: reduce syscalls in first probe of /proc
open/access/close is cheaper than open/stat/stat/close.
Use O_DIRECTORY for safety.
* lib/openat-proc.c (openat_proc_name): Require that /proc/self/fd
be a directory. Simplify the probe for .. bugs.
* modules/openat (Depends-on): Drop same-inode.
Reported by Bastien ROUCARIES.
Signed-off-by: Eric Blake <eblake@redhat.com>
Karl Berry [Mon, 9 May 2011 18:06:26 +0000 (11:06 -0700)]
autoupdate
Jim Meyering [Mon, 9 May 2011 17:28:11 +0000 (19:28 +0200)]
maint.mk: change semantics/name of tight_scope variables
* top/maint.mk (_gl_TS_var_match, _gl_TS_function_match):
Rename variables to align with semantics that make them more useful.
Jim Meyering [Mon, 9 May 2011 11:29:38 +0000 (13:29 +0200)]
maint.mk: fix oops
* top/maint.mk (sc_tight_scope): Fix last change: missing backslash.
Jim Meyering [Mon, 9 May 2011 11:27:55 +0000 (13:27 +0200)]
maint.mk: tweak new rule's name not to impinge
* top/maint.mk (_gl_tight_scope): Rename from sc_tight_scope-0.
(sc_tight_scope): Use new rule name rather than $@-0.
Jim Meyering [Mon, 9 May 2011 10:30:55 +0000 (12:30 +0200)]
maint.mk: add a syntax-check rule to ensure tightly-scoped symbols
* top/maint.mk (sc_tight_scope): New rule.
(sc_tight_scope-0): New rule, ifdef'd out.
(_gl_TS_dir): Default.
(_gl_TS_unmarked_extern_functions, _gl_TS_function_regex): Define.
(_gl_TS_unmarked_extern_vars, _gl_TS_var_regex): Define.
Simon Josefsson [Mon, 9 May 2011 07:07:13 +0000 (09:07 +0200)]
gc: Remove gl_PREREQ_GC (not used).
* m4/gc.m4: Remove gl_PREREQ_GC (not used). Reported by Bruno
Haible <bruno@clisp.org>.
Bruno Haible [Sun, 8 May 2011 23:11:59 +0000 (01:11 +0200)]
Comments.
* m4/isnanf.m4: Add comment.
* m4/isnanl.m4: Likewise.
Bruno Haible [Sun, 8 May 2011 18:39:07 +0000 (20:39 +0200)]
glob: Remove obsolete macro.
* m4/glob.m4 (gl_GLOB_SUBSTITUTE): Remove macro.
Paul Eggert [Sun, 8 May 2011 19:28:01 +0000 (12:28 -0700)]
intprops: Sun C 5.11 supports __typeof__
* lib/intprops.h (_GL_HAVE___TYPEOF__): New macro, which is set
for either GCC 2 or later, as before, or for Sun C 5.11 or later,
which is new.
(_GL_SIGNED_TYPE_OR_EXPR): Use it.
Paul Eggert [Sun, 8 May 2011 18:53:53 +0000 (11:53 -0700)]
intprops: switch to usual gnulib indenting and naming
* lib/intprops.h (_GL_INTPROPS_H): Rename from GL_INTPROPS_H.
(_GL_SIGNED_TYPE_OR_EXPR): Rename from signed_type_or_expr__.
* tests/test-inttostr.c (IS_TIGHT): Adjust to above renaming.
Jim Meyering [Sun, 8 May 2011 16:13:59 +0000 (18:13 +0200)]
maint.mk: suppress "Entering/Leaving directory" diag in announcement
* top/maint.mk (release-prep): Use make's --no-print-directory
option when generating the announcement. This eliminates the
pesky "make[2]: Entering/Leaving directory" diagnostics in the
generated announcement template.
Bruno Haible [Sun, 8 May 2011 16:09:39 +0000 (18:09 +0200)]
tzset: Fix gettimeofday wrapper on Solaris 2.6.
* m4/tzset.m4 (gl_FUNC_TZSET_CLOBBER): When invoking
gl_GETTIMEOFDAY_REPLACE_LOCALTIME, also set REPLACE_GETTIMEOFDAY.
Paul Eggert [Sat, 7 May 2011 21:29:30 +0000 (14:29 -0700)]
ignore-value, verify: Omit include files from lib_SOURCES.
* modules/ignore-value, modules/verify (Makefile.am):
Don't put ignore-value.h, or verify.h, into lib_SOURCES, as
that leads Automake to duplicate use of am__objects_... variables
in Makefile.in. See
<http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00257.html>.
Bruno Haible [Sat, 7 May 2011 11:05:51 +0000 (13:05 +0200)]
fclose: Simplify autoconf macro.
* m4/fclose.m4 (gl_FUNC_FCLOSE): Assume gl_FUNC_FFLUSH_STDIN is
defined.
Bruno Haible [Sat, 7 May 2011 10:50:30 +0000 (12:50 +0200)]
canonicalize-lgpl: Fix autoconf macro ordering bug.
* m4/canonicalize.m4 (gl_CANONICALIZE_LGPL): Require
gl_STDLIB_H_DEFAULTS.
Eric Blake [Fri, 6 May 2011 21:38:46 +0000 (15:38 -0600)]
maintainer-makefile: make sc_po_check easier to tune
* top/maint.mk (sc_po_check): Allow overriding which non-VC files
to probe for strings, such as an alternate location for gnulib.
Signed-off-by: Eric Blake <eblake@redhat.com>
Eric Blake [Fri, 6 May 2011 19:01:17 +0000 (13:01 -0600)]
fclose: guarantee behavior on seekable stdin
* modules/fclose (Depends-on): Add fflush.
* doc/posix-functions/fclose.texi (fclose): Document this.
* tests/test-fclose.c (main): Make test for this unconditional.
Signed-off-by: Eric Blake <eblake@redhat.com>
Bruno Haible [Fri, 6 May 2011 18:14:41 +0000 (20:14 +0200)]
fflush, fpurge: Relicense under LGPLv2+.
* modules/fflush (License): Change from LGPLv3+ to LGPLv2+.
* modules/fpurge (License): Likewise.
With permission from Eric Blake and Jim Meyering.
Suggested by Eric Blake.
Karl Berry [Fri, 6 May 2011 16:31:16 +0000 (09:31 -0700)]
rm exit module
Jim Meyering [Fri, 6 May 2011 06:09:21 +0000 (08:09 +0200)]
maint.mk: use info-gnu@ as the default only for a stable release
* top/maint.mk: Don't default to info-gnu for alpha or beta releases.
For those, just use $(PACKAGE_BUGREPORT), in which case we don't have
to set the Mail-Followup-To header. Prompted by Reuben Thomas in
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/26488
Paul Eggert [Fri, 6 May 2011 05:43:18 +0000 (22:43 -0700)]
assert-h: new module, which supports C1X-style static_assert
* lib/assert.in.h, m4/assert_h.m4, modules/assert-h: New files.
* lib/verify.h: Revamp so that this can be copied into assert.h,
while retaining the ability to use it standalone as before.
Rename private identifiers so as not to encroach on the
standard C namespace, since this is now used by assert.h.
(_GL_VERIFY_TYPE): New macro, factoring out differing parts of
the old verify_true.
(_GL_VERIFY_TRUE): New macro, with much of the contents of
the old verify_true. Use _GL_VERIFY_TYPE.
(_GL_VERIFY): New macro, with much of the contents of the old verify.
(static_assert): New macro, if _GL_STATIC_ASSERT_H
is defined and static_assert is not; _GL_STATIC_ASSERT_H is
defined when this file is copied into the replacement assert.h.
(_Static_assert): New macro, if _GL_STATIC_ASSERT_H is defined
and _Static_assert is not built in.
(verify_true, verify): Define only if _GL_STATIC_ASSERT_H is not
defined, and use the new macros mentioned above.
* doc/posix-headers/assert.texi: Document this.
Bruno Haible [Thu, 5 May 2011 22:34:34 +0000 (00:34 +0200)]
fclose, fflush: Respect rules for use of AC_LIBOBJ.
* m4/fflush.m4 (gl_FUNC_FFLUSH): Don't invoke gl_REPLACE_FCLOSE.
* m4/fclose.m4 (gl_FUNC_FCLOSE): Invoke gl_FUNC_FFLUSH_STDIN and
gl_REPLACE_FCLOSE here.
* modules/fflush (Depends-on): Remove fclose.
* doc/posix-functions/fclose.texi: Mention module 'fflush' only in
combination with module 'fclose'.
Bruno Haible [Thu, 5 May 2011 22:23:55 +0000 (00:23 +0200)]
fflush, fseeko: Respect rules for use of AC_LIBOBJ.
* m4/fflush.m4 (gl_FUNC_FFLUSH_STDIN): New macro, extracted from
gl_FUNC_FFLUSH.
(gl_FUNC_FFLUSH): Use it.
(gl_REPLACE_FFLUSH): Don't invoke gl_REPLACE_FSEEKO.
* m4/fseeko.m4 (gl_FUNC_FSEEKO): Invoke gl_FUNC_FFLUSH_STDIN and
gl_REPLACE_FSEEKO here.