From: Jim Meyering <meyering@redhat.com>
Date: Fri, 26 Mar 2010 08:04:29 +0000 (+0100)
Subject: maint.mk: prohibit use of test's -o and -a operators
X-Git-Tag: v0.1~4402
X-Git-Url: http://erislabs.org.uk/gitweb/?a=commitdiff_plain;h=a69383361372107681975a9af73d9a4059e8d178;p=gnulib.git

maint.mk: prohibit use of test's -o and -a operators

* top/maint.mk (sc_prohibit_test_minus_ao): New rule.
---

diff --git a/ChangeLog b/ChangeLog
index 259a81184..12e072206 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-03-26  Jim Meyering  <meyering@redhat.com>
+	    Eric Blake  <eblake@redhat.com>
+
+	maint.mk: prohibit use of test's -o and -a operators
+	* top/maint.mk (sc_prohibit_test_minus_ao): New rule.
+
 2010-03-28  Bruno Haible  <bruno@clisp.org>
 
 	Remove unused GNULIB_XYZ macro definitions.
diff --git a/top/maint.mk b/top/maint.mk
index 6127c572f..d63318858 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -593,6 +593,14 @@ sc_prohibit_S_IS_definition:
 	msg='do not define S_IS* macros; include <sys/stat.h>'		\
 	  $(_prohibit_regexp)
 
+_ptm1 = use "test C1 && test C2", not "test C1 -''a C2"
+_ptm2 = use "test C1 || test C2", not "test C1 -''o C2"
+# Using test's -a and -o operators is not portable.
+sc_prohibit_test_minus_ao:
+	@re='\<test .+ -[ao] '						\
+	msg='$(_ptm1); $(_ptm2)'						\
+	  $(_prohibit_regexp)
+
 # Each program that uses proper_name_utf8 must link with one of the
 # ICONV libraries.  Otherwise, some ICONV library must appear in LDADD.
 # The perl -0777 invocation below extracts the possibly-multi-line