From: Eric Blake <eblake@redhat.com>
Date: Fri, 16 Sep 2011 16:28:13 +0000 (-0600)
Subject: test-fsync: enhance tests
X-Git-Tag: v0.1~1905
X-Git-Url: http://erislabs.org.uk/gitweb/?a=commitdiff_plain;h=9a0a67e426f31b06f0e3f202618094f6f582c5db;p=gnulib.git

test-fsync: enhance tests

This test failed to compile on mingw, which lacks ENOTSUP.  Furthermore,
it wasn't testing POSIX behavior on invalid fds.

* modules/fsync-tests (Depends-on): Add errno, for mingw.
* tests/test-fsync.c (main): Enhance test.

Signed-off-by: Eric Blake <eblake@redhat.com>
---

diff --git a/ChangeLog b/ChangeLog
index 3717d06a5..e1f97a0c1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-09-16  Eric Blake  <eblake@redhat.com>
+
+	test-fsync: enhance tests
+	* modules/fsync-tests (Depends-on): Add errno, for mingw.
+	* tests/test-fsync.c (main): Enhance test.
+
 2011-09-15  Bruno Haible  <bruno@clisp.org>
 
 	Support for MSVC compiler: Ensure ssize_t gets defined.
diff --git a/modules/fsync-tests b/modules/fsync-tests
index e3df22dbb..3db181be7 100644
--- a/modules/fsync-tests
+++ b/modules/fsync-tests
@@ -4,6 +4,7 @@ tests/signature.h
 tests/macros.h
 
 Depends-on:
+errno
 
 configure.ac:
 
diff --git a/tests/test-fsync.c b/tests/test-fsync.c
index 2627d0cba..11c047899 100644
--- a/tests/test-fsync.c
+++ b/tests/test-fsync.c
@@ -32,13 +32,16 @@ main (void)
   int fd;
   const char *file = "test-fsync.txt";
 
-  if (fsync (0) != 0)
+  if (fsync (STDOUT_FILENO) != 0)
     {
       ASSERT (errno == EINVAL /* POSIX */
               || errno == ENOTSUP /* seen on MacOS X 10.5 */
               || errno == EBADF /* seen on AIX 7.1 */
-             );
+              );
     }
+  errno = 0;
+  ASSERT (fsync (-1) == -1);
+  ASSERT (errno == EBADF);
   fd = open (file, O_WRONLY|O_CREAT|O_TRUNC, 0644);
   ASSERT (0 <= fd);
   ASSERT (write (fd, "hello", 5) == 5);