From: Jim Meyering <meyering@redhat.com>
Date: Thu, 2 Feb 2012 08:12:13 +0000 (+0100)
Subject: file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const
X-Git-Tag: v0.1~1183
X-Git-Url: http://erislabs.org.uk/gitweb/?a=commitdiff_plain;h=93f8bee70d1bc611bead8a826edf0a932c2b8999;p=gnulib.git

file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const

* lib/file-has-acl.c (file_has_acl): This function (for some #ifdefs)
would evoke a new gcc warning.  Given all of the #ifdefs, it is better
not even to try to add the attribute.  Instead, add a pragma to suppress
the suggestion/warning.
---

diff --git a/ChangeLog b/ChangeLog
index f80c7dda9..9c5a3cdc5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2012-02-02  Jim Meyering  <meyering@redhat.com>
+
+	file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const
+	* lib/file-has-acl.c (file_has_acl): This function (for some #ifdefs)
+	would evoke a new gcc warning.  Given all of the #ifdefs, it is better
+	not even to try to add the attribute.  Instead, add a pragma to suppress
+	the suggestion/warning.
+
 2012-01-31  Karl Berry  <karl@gnu.org>
 
 	setstate doc: typo.
diff --git a/lib/file-has-acl.c b/lib/file-has-acl.c
index b7c148451..89a63a658 100644
--- a/lib/file-has-acl.c
+++ b/lib/file-has-acl.c
@@ -17,6 +17,12 @@
 
    Written by Paul Eggert, Andreas Grünbacher, and Bruno Haible.  */
 
+/* Without this pragma, gcc 4.7.0 20120126 may suggest that the
+   file_has_acl function might be candidate for attribute 'const'  */
+#if (__GNUC__ == 4 && 6 <= __GNUC_MINOR__) || 4 < __GNUC__
+# pragma GCC diagnostic ignored "-Wsuggest-attribute=const"
+#endif
+
 #include <config.h>
 
 #include "acl.h"