From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 21 Feb 2007 20:49:59 +0000 (+0000)
Subject: * lib/getcwd.c (__getcwd): Undo previous change; it mishandled
X-Git-Tag: cvs-readonly~1001
X-Git-Url: http://erislabs.org.uk/gitweb/?a=commitdiff_plain;h=8436691c12d9e2397dcd604c7ea261314520af9a;p=gnulib.git

* lib/getcwd.c (__getcwd): Undo previous change; it mishandled
long unreadable paths in GNU/Linux.  Problem reported by Andreas
Schwab in
<http://lists.gnu.org/archive/html/bug-gnulib/2007-02/msg00261.html>.
I'll try to think of a better way to fix the Solaris problem.
---

diff --git a/ChangeLog b/ChangeLog
index 0f1e117ca..19d29222e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2007-02-21  Paul Eggert  <eggert@cs.ucla.edu>
 
+	* lib/getcwd.c (__getcwd): Undo previous change; it mishandled
+	long unreadable paths in GNU/Linux.  Problem reported by Andreas
+	Schwab in
+	<http://lists.gnu.org/archive/html/bug-gnulib/2007-02/msg00261.html>.
+	I'll try to think of a better way to fix the Solaris problem.
+
 	* lib/getcwd.c (__getcwd): Don't assume getcwd (NULL, 0) works
 	like glibc; on Solaris 10, it fails with errno == EINVAL.
 	POSIX says the behavior is unspecified if the first argument is NULL,
diff --git a/lib/getcwd.c b/lib/getcwd.c
index 3ccfbdf46..f8567bd73 100644
--- a/lib/getcwd.c
+++ b/lib/getcwd.c
@@ -141,6 +141,24 @@ __getcwd (char *buf, size_t size)
   size_t allocated = size;
   size_t used;
 
+#if HAVE_PARTLY_WORKING_GETCWD
+  /* The system getcwd works, except it sometimes fails when it
+     shouldn't, setting errno to ERANGE, ENAMETOOLONG, or ENOENT.  If
+     AT_FDCWD is not defined, the algorithm below is O(N**2) and this
+     is much slower than the system getcwd (at least on GNU/Linux).
+     So trust the system getcwd's results unless they look
+     suspicious.
+
+     Use the system getcwd even if we have openat support, since the
+     system getcwd works even when a parent is unreadable, while the
+     openat-based approach does not.  */
+
+# undef getcwd
+  dir = getcwd (buf, size);
+  if (dir || (errno != ERANGE && !is_ENAMETOOLONG (errno) && errno != ENOENT))
+    return dir;
+#endif
+
   if (size == 0)
     {
       if (buf != NULL)
@@ -161,30 +179,6 @@ __getcwd (char *buf, size_t size)
   else
     dir = buf;
 
-#if HAVE_PARTLY_WORKING_GETCWD
-  /* The system getcwd works, except it sometimes fails when it
-     shouldn't, setting errno to ERANGE, ENAMETOOLONG, or ENOENT.  If
-     AT_FDCWD is not defined, the algorithm below is O(N**2) and this
-     is much slower than the system getcwd (at least on GNU/Linux).
-     So trust the system getcwd's results unless they look
-     suspicious.
-
-     Use the system getcwd even if we have openat support, since the
-     system getcwd works even when a parent is unreadable, while the
-     openat-based approach does not.  */
-
-# undef getcwd
-  if (getcwd (dir, allocated))
-    {
-      if (buf == NULL && size == 0)
-	buf = realloc (dir, strlen (dir) + 1);
-      return (buf ? buf : dir);
-    }
-
-  if (! (errno == ERANGE || is_ENAMETOOLONG (errno) || errno == ENOENT))
-    return NULL;
-#endif
-
   dirp = dir + allocated;
   *--dirp = '\0';