From: Jim Meyering <meyering@redhat.com>
Date: Sun, 7 Dec 2008 17:47:02 +0000 (+0100)
Subject: posixtm.c: avoid a warning
X-Git-Tag: v0.1~6629
X-Git-Url: http://erislabs.org.uk/gitweb/?a=commitdiff_plain;h=37bc76801091560c6f1be54925d2942c0f66912a;p=gnulib.git

posixtm.c: avoid a warning

* lib/posixtm.c (posixtime): Don't initialize tm0.
It's no longer needed to placate gcc4's -Wuninitialized,
and the attempt to placate would elicit a new warning.
---

diff --git a/ChangeLog b/ChangeLog
index 2865b547e..5f11392c7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-12-07  Jim Meyering  <meyering@redhat.com>
 
+	posixtm.c: avoid a warning
+	* lib/posixtm.c (posixtime): Don't initialize tm0.
+	It's no longer needed to placate gcc4's -Wuninitialized,
+	and the attempt to placate would elicit a new warning.
+
 	unicodeio.c: mark unused parameters
 	* lib/unicodeio.c (exit_failure_callback): Mark unused parameter.
 	(fallback_failure_callback): Likewise.
diff --git a/lib/posixtm.c b/lib/posixtm.c
index fff53f50b..7740f4d9d 100644
--- a/lib/posixtm.c
+++ b/lib/posixtm.c
@@ -186,15 +186,7 @@ posix_time_parse (struct tm *tm, const char *s, unsigned int syntax_bits)
 bool
 posixtime (time_t *p, const char *s, unsigned int syntax_bits)
 {
-  struct tm tm0
-#ifdef lint
-  /* Placate gcc-4's -Wuninitialized.
-     posix_time_parse fails to set all of tm0 only when it returns
-     nonzero (due to year() returning nonzero), and in that case,
-     this code doesn't use the tm0 at all.  */
-    = { 0, }
-#endif
-    ;
+  struct tm tm0;
   struct tm tm1;
   struct tm const *tm;
   time_t t;