cloexec: Clarify code.

diff --git a/ChangeLog b/ChangeLog
index 8597a13..871ac1e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2009-12-09  Bruno Haible  <bruno@clisp.org>
+
+       * lib/cloexec.c (set_cloexec_flag): Clarify intent of dup2 call.
+
 2009-12-08  Eric Blake  <ebb9@byu.net>
 
        fchdir: avoid memory leak on re-registration.

diff --git a/lib/cloexec.c b/lib/cloexec.c
index 18985cb..69b45b4 100644 (file)
--- a/lib/cloexec.c
+++ b/lib/cloexec.c
@@ -71,8 +71,12 @@ set_cloexec_flag (int desc, bool value)
       errno = EBADF;
       return -1;
     }
-  return dup2 (desc, desc) == desc ? 0 : -1;
+  if (dup2 (desc, desc) < 0)
+    /* errno is EBADF here.  */
+    return -1;
 
+  /* There is nothing we can do on this kind of platform.  Punt.  */
+  return 0;
 #endif
 }